[FFmpeg-devel] [PATCH] lavf/mov.c: Fix timestamps to be strictly monotonic for video also.
Michael Niedermayer
michael at niedermayer.cc
Sun Apr 1 01:16:57 EEST 2018
On Thu, Mar 29, 2018 at 03:58:09PM -0700, Sasi Inguva wrote:
> Signed-off-by: Sasi Inguva <isasi at isasi.mtv.corp.google.com>
> ---
> libavformat/mov.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
The commit message should explain why this change is done.
Not just what is changed
[...]
> @@ -3594,7 +3595,7 @@ static void mov_fix_index(MOVContext *mov, AVStream *st)
> edit_list_start_encountered = 1;
> // Make timestamps strictly monotonically increasing for audio, by rewriting timestamps for
> // discarded packets.
> - if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO && frame_duration_buffer) {
> + if (frame_duration_buffer) {
The comment above needs an update too i think
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180401/91a28c56/attachment.sig>
More information about the ffmpeg-devel
mailing list