[FFmpeg-devel] [PATCH v3 2/3] avutil/log: add av_log_set_opts function
Tobias Rapp
t.rapp at noa-archive.com
Tue Apr 3 11:51:36 EEST 2018
On 03.04.2018 10:25, Paul B Mahol wrote:
> On 4/3/18, Tobias Rapp <t.rapp at noa-archive.com> wrote:
>> On 29.03.2018 20:38, Michael Niedermayer wrote:
>>> On Wed, Mar 28, 2018 at 05:03:39PM +0200, Tobias Rapp wrote:
>>>> Allows to set log level and flag values from string.
>>>>
>>>> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
>>>> ---
>>>> doc/APIchanges | 3 +++
>>>> libavutil/log.c | 76
>>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>> libavutil/log.h | 16 +++++++++++
>>>> libavutil/version.h | 2 +-
>>>> 4 files changed, 96 insertions(+), 1 deletion(-)
>>>
>>> iam not intending to override anyone blocking this but as i looked at the
>>> code
>>> and it LGTM
>>
>> Thanks for review. Moved code into fftools/cmdutils.c and pushed to
>> master. Will send a separate patch to ML for the missing documentation
>> update.
>
> This was blocked, please revert ASAP!
As far as I understood the responses from wm4 and Michael it was blocked
to be added in libavutil/log.c but accepted to be added in
fftools/cmdutils.c (as in version 2 of the patch it was only a
suggestion to move the code to libavutil).
Regards,
Tobias
More information about the ffmpeg-devel
mailing list