[FFmpeg-devel] [PATCH] lavc/libopusdec: Allow avcodec_open2 to call .close

[Michael Niedermayer]

On Wed, Apr 11, 2018 at 12:43:21AM +0200, Michael Niedermayer wrote:
> On Tue, Apr 10, 2018 at 02:13:28PM -0700, Matthew Wolenetz wrote:
> > 
> 
> >  libopusdec.c |    6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > a62bece9f45c68d93e138cb021a533fbc242ddc3  0001-lavc-libopusdec-Allow-avcodec_open2-to-call-.close.patch
> > From 031e96bd481b7b8d0c11e5353f74fafc69e37f09 Mon Sep 17 00:00:00 2001
> > From: Matt Wolenetz <wolenetz at google.com>
> > Date: Tue, 10 Apr 2018 13:59:25 -0700
> > Subject: [PATCH] lavc/libopusdec: Allow avcodec_open2 to call .close
> > 
> > If there is a decoder initialization failure detected in avcodec_open2
> > after .init is called, allow graceful decoder .close to prevent leaking
> > libopus decoder allocations.
> > 
> > BUG=828526
> > ---
> >  libavcodec/libopusdec.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> Doesnt apply, also the NULL check already exists in git master
> FF_CODEC_CAP_INIT_CLEANUP is missing in master though
> 
> can you update the patch ?

forget this, will apply your patch

i had this applied locally and didnt realize, i even checked
what patches i had on the changed file, somehow i must have
done something silly

commit 4614d94f049319353f6c9deba1079009dd85594c 
Author: Andrew Allen <bitllama at google.com>
Date:   Wed Mar 28 14:48:46 2018 -0700

    Support for Ambisonics and OpusProjection* API.
    
    Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180411/1fa86202/attachment.sig>