[FFmpeg-devel] [PATCH] tests/checkasm/aacpsdsp: Increase EPS for interpolate so that the test passes on kfreebsd

[Michael Niedermayer]

On Sun, Apr 15, 2018 at 06:16:52PM -0300, James Almer wrote:
> On 4/15/2018 5:51 PM, Michael Niedermayer wrote:
> > The value is minimal, 0.11 fails
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tests/checkasm/aacpsdsp.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/checkasm/aacpsdsp.c b/tests/checkasm/aacpsdsp.c
> > index ea68b39fa9..9e30eaa497 100644
> > --- a/tests/checkasm/aacpsdsp.c
> > +++ b/tests/checkasm/aacpsdsp.c
> > @@ -33,6 +33,7 @@
> >  } while (0)
> >  
> >  #define EPS 0.005
> > +#define EPS2 0.12
> 
> That's kind of like a lot, but to be fair 0.005 was already a lot as
> well, considering other tests succeed with just FLT_EPSILON or values
> like 0.0000007.
> 
> Should be ok if that's really the smallest value that succeeds.

its worse, 0.4 would be needed at least it seems. I withdraw this
patch for now. It would be more ideal if the implementation could be
made more precisse.

If this doesnt happen we can still go back to this and apply it with 0.4


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180416/ee603fa2/attachment.sig>