[FFmpeg-devel] [PATCH 2/2] lavc/encode: fix frame_number double-counted

[Li, Zhong]

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Michael Niedermayer
> Sent: Saturday, July 28, 2018 3:28 AM
> To: FFmpeg development discussions and patches
> <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/encode: fix frame_number
> double-counted
> 
> On Thu, Jul 26, 2018 at 03:51:07PM +0800, Zhong Li wrote:
> > Encoder frame_number may be double-counted if some frames are cached
> and then flushed.
> > Take qsv encoder (some frames are cached firsty for asynchronism) as
> > example, ./ffmpeg -loglevel verbose -hwaccel qsv -c:v h264_qsv -i
> > in.mp4 -vframes 100 -c:v h264_qsv out.mp4 frame_number passed to
> encoder is double-counted and larger than the accurate value.
> > Libx264 encoding with B frames can also reproduce it.
> >
> > Signed-off-by: Zhong Li <zhong.li at intel.com>
> > ---
> >  libavcodec/encode.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> probably ok

Thanks for review. Will push it if without any other comments.


> [...]
> --
> Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Into a blind darkness they enter who follow after the Ignorance, they as if
> into a greater darkness enter who devote themselves to the Knowledge
> alone. -- Isha Upanishad