[FFmpeg-devel] [PATCH 4/4] lavc/mpeg4videodec: fix can't dump AVOptions issue.

[Michael Niedermayer]

On Wed, Aug 15, 2018 at 08:44:31AM +0800, mypopy at gmail.com wrote:
> On Tue, Aug 14, 2018 at 11:39 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> >
> > On Mon, Aug 13, 2018 at 09:51:47PM +0800, Jun Zhao wrote:
> > > fix can't dump the mpeg4videodec option with the command
> > > "ffmpeg -h decoder=mpeg4".
> > >
> > > Signed-off-by: Jun Zhao <mypopydev at gmail.com>
> > > ---
> > >  libavcodec/mpeg4videodec.c |    5 +++--
> > >  1 files changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
> > > index 24c280d..549b7a5 100644
> > > --- a/libavcodec/mpeg4videodec.c
> > > +++ b/libavcodec/mpeg4videodec.c
> > > @@ -3435,9 +3435,10 @@ static av_cold int decode_end(AVCodecContext
> *avctx)
> > >      return ff_h263_decode_end(avctx, just );
> > >  }
> > >
> > > +#define VD AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_DECODING_PARAM
> > >  static const AVOption mpeg4_options[] = {
> > > -    {"quarter_sample", "1/4 subpel MC", offsetof(MpegEncContext,
> quarter_sample), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, 0},
> > > -    {"divx_packed", "divx style packed b frames",
> offsetof(MpegEncContext, divx_packed), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1,
> 0},
> > > +    {"quarter_sample", "1/4 subpel MC", offsetof(MpegEncContext,
> quarter_sample), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, VD},
> > > +    {"divx_packed", "divx style packed b frames",
> offsetof(MpegEncContext, divx_packed), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1,
> VD},
> > >      {NULL}
> >
> > These are not options for the user to set, they are not supposed to be
> > in the "ffmpeg -h decoder=mpeg4" listing
> >
> >
> What's the reason
> to
> use the mpeg4_option for quarter_sample/divx_packed,  just want to
> initialize them?

They are there so the user application can access (read) their values cleanly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180816/90663a5d/attachment.sig>