[FFmpeg-devel] [PATCH 4/7] Adds gray floating-point pixel formats.

[James Almer]

On 8/17/2018 9:52 AM, Carl Eugen Hoyos wrote:
> 2018-08-17 14:21 GMT+02:00, Sergey Lavrushkin <dualfal at gmail.com>:
>> пт, 17 авг. 2018 г., 6:47 James Almer <jamrial at gmail.com>:
>>
>>> On 8/14/2018 1:23 PM, Michael Niedermayer wrote:
>>>> On Mon, Aug 13, 2018 at 04:58:42PM +0300, Sergey Lavrushkin wrote:
>>>>>>
>>>>>> Just use av_clipf instead of FFMIN/FFMAX.
>>>>>
>>>>>
>>>>> Changed FFMIN/FFMAX to av_clip_uint16 and av_clip_uint8.
>>>>
>>>> will apply
>>>>
>>>> thanks
>>>
>>> This broke fate on some 32bit hosts. Guess float pixfmts shouldn't be
>>> tested for bitexact output. The gbrpf32 ones aren't, for example.
>>>
>>> http://fate.ffmpeg.org/report.cgi?time=20180816131312&slot=x86_32-debian-kfreebsd-gcc-4.4-cpuflags-mmx
>>
>>
>> If I am not mistaken, gbrpf32 formats are not supported in libswscale
>> [because of that]
> 
> I sincerely hope that this is not true...
> 
>> and not tested because of that.
>>
>>>
>>> Was a float gray pixfmt needed for this filter? Gray16 was not an option?
>>>
>>
>> All calculations in neural network are done using floats.
>>
>> What can I do to fix this issue?
> 
> Reverting to doing the conversion in the filter comes to mind...
> 
> Carl Eugen

We asked him to remove the conversions from the filter, so we're not
going to tell him to roll everything back...