[FFmpeg-devel] [PATCH] avformat/tls_schannel: Fix use of uninitialized variable

[Thilo Borgmann]

Am 17.08.18 um 14:51 schrieb Carl Eugen Hoyos:
> 2018-08-17 14:36 GMT+02:00, Hendrik Leppkes <h.leppkes at gmail.com>:
>> On Fri, Aug 17, 2018 at 12:05 PM Paweł Wegner <pawel.wegner95 at gmail.com>
>> wrote:
>>>
>>> Yes, it will work.
>>>
>>> Fixes: runtime error: passing uninitialized value to FreeContextBuffer
>>> causes a crash
>>>
>>> Signed-off-by: Paweł Wegner <pawel.wegner95 at gmail.com>
>>> ---
>>>  libavformat/tls_schannel.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/tls_schannel.c b/libavformat/tls_schannel.c
>>> index f41b007773..4f0badcb8d 100644
>>> --- a/libavformat/tls_schannel.c
>>> +++ b/libavformat/tls_schannel.c
>>> @@ -148,7 +148,7 @@ static int tls_client_handshake_loop(URLContext *h,
>>> int initial)
>>>      TLSContext *c = h->priv_data;
>>>      TLSShared *s = &c->tls_shared;
>>>      SECURITY_STATUS sspi_ret;
>>> -    SecBuffer outbuf[3];
>>> +    SecBuffer outbuf[3] = { 0 };
>>>      SecBufferDesc outbuf_desc;
>>>      SecBuffer inbuf[2];
>>>      SecBufferDesc inbuf_desc;
>>> --
>>> 2.17.1
>>>
>>
>> LGTM.
> 
> Then please commit.

Pushed.

-Thilo