[FFmpeg-devel] [PATCH] lavc/hevc_ps: fix crop info for monochrome

[Zhao Zhili]

On 2018年08月18日 05:33, Michael Niedermayer wrote:
> On Fri, Aug 17, 2018 at 09:52:57AM +0800, Zhao Zhili wrote:
>> The values of SubWidthC and SubHeightC are 1 in the ITU-T H.265. The
>> current code use the value of 2.
>> ---
>>   libavcodec/hevc_ps.c | 16 ++++++++++++----
>>   1 file changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
>> index fbd9fbf..b56b078 100644
>> --- a/libavcodec/hevc_ps.c
>> +++ b/libavcodec/hevc_ps.c
>> @@ -70,6 +70,14 @@ static const AVRational vui_sar[] = {
>>       {  2,   1 },
>>   };
>>   
>> +static const unsigned hevc_sub_width_c[] = {
> uint8_t saves a few bytes
>
> more important, the commit message should mention a ticket or test sample
> also a fate test with a _small_ testsample would be usefull. Obviously
> the existing tests do not cover this
>

The bug was found by reading the source code. There is no ticket
related to the bug. I need some time to download the test suite
and figure out how it work. Feel free to add the test if anyone
has a suitable sample.

> thx
>
> [...]
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel