[FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

Michael Niedermayer michael at niedermayer.cc
Wed Aug 22 03:34:21 EEST 2018


On Mon, Aug 20, 2018 at 01:03:31PM -0700, Fredrik Hubinette wrote:
> Ok, let's use cast, new patch attached.
> 
> 
> On Mon, Jul 30, 2018 at 4:53 PM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > On Mon, Jul 30, 2018 at 01:49:24PM -0700, Fredrik Hubinette wrote:
> > > Is casting a negative integer to unsigned defined behavior?
> >
> > yes
> >
> > 6.3.1.3 Signed and unsigned integers
> >
> > 2 Otherwise, if the new type is unsigned, the value is converted by
> > repeatedly adding or
> >   subtracting one more than the maximum value that can be represented in
> > the new type
> >   until the value is in the range of the new type.49)
> >
> > [...]
> > --
> > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >
> > I do not agree with what you have to say, but I'll defend to the death your
> > right to say it. -- Voltaire
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  utils.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> bc4877b8167668c81cf978a7e3cecfc412ca8c92  0001-avoid-undefined-integer-overflow-behavior.patch
> From e8f3a5a4ff9b89b33f4067c7aa735fff9895333e Mon Sep 17 00:00:00 2001
> From: Fredrik Hubinette <hubbe at google.com>
> Date: Mon, 20 Aug 2018 12:59:32 -0700
> Subject: [PATCH] avoid undefined integer overflow behavior

will apply

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180822/e073f993/attachment.sig>


More information about the ffmpeg-devel mailing list