[FFmpeg-devel] [PATCH 2/2] avformat/movenc: support Opus packets with more than 60ms of audio when writing the Sample Group Description Box

[Nicolas George]

James Almer (2018-08-24):
> Invalid input (say, a packet reporting a frame size of the equivalent of
> 1ms) would assert before and after this patch. Do you consider an assert
> that triggers on invalid input to be wrong? I thought that was the
> entire point of one...

Assert failures cause an immediate exit and core dump. If a crafted
input can trigger a failure and crash the application, that is a serious
problem. Asserts are there to catch bugs.

> If you prefer i can remove the entire assert altogether. Or maybe
> replace it with a normal check that returns an error instead.

If you just remove the assert, then the invalid value is passed to the
rest of the code. You know better than me how it will react to it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180824/3f0a38e6/attachment.sig>