[FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

[Andrey Semashev]

On 12/4/18 2:47 PM, Andrey Semashev wrote:
> On 12/4/18 11:49 AM, Jeyapal, Karthick wrote:
>>
>> On 11/29/18 8:28 PM, Andrey Semashev wrote:
>>> On 11/28/18 7:25 PM, Jeyapal, Karthick wrote:
>>>>
>>>> On 11/28/18 4:41 PM, Andrey Semashev wrote:
>>>>> The global_sidx flag causes errors like the following in movenc 
>>>>> when media
>>>>> segment removal is enabled via windos_size or remove_at_exit:
>>>>>
>>>>> Non-consecutive fragments, writing incorrect sidx
>>>>> Unable to re-open  output file for the second pass (faststart)
>>>> Removing global_sidx flag adds sidx atom to each moof fragment 
>>>> adding significant bitrate overhead.
>>>> Instead I have submitted a patch to handle this case cleanly in 
>>>> movenc. 
>>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2018-November/236873.html
>>>> Please try the above patch and let me know if that will work for you.
>>>
>>> Yes, that patch seems to fix the errors. Thanks.
>> Hi Andrey,
>>
>> That patch was not pushed due to some objections. I have submitted a 
>> new patch set addressing it.
>> http://ffmpeg.org/pipermail/ffmpeg-devel/2018-December/237121.html
>> Could you please try the above patchset and confirm if everything 
>> works as expected?
> 
> I will test the final version. Though, if it doesn't change the effect 
> since the last version then it should work as well.

I have tested v2 with the fixed flags setup as noted by Tobias and don't 
see any errors.