[FFmpeg-devel] [PATCH v4] avformat/movenc: Added an option to disable SIDX atom

[Ronak]

> On Dec 11, 2018, at 1:42 PM, Ronak <ronak2121 at yahoo.com> wrote:
> 
> 
> 
>> On Dec 11, 2018, at 12:35 AM, Jeyapal, Karthick <kjeyapal at akamai.com> wrote:
>> 
>> 
>> 
>> On 12/11/18, 9:07 AM, "Ronak" <ronak2121-at-yahoo.com at ffmpeg.org> wrote:
>> 
>>> 
>>>> On Dec 6, 2018, at 4:47 AM, Tobias Rapp <t.rapp at noa-archive.com> wrote:
>>>> 
>>>> On 06.12.2018 08:28, Karthick J wrote:
>>>>> ---
>>>>> [...]
>>>> 
>>>> Looks OK now, no more comments from my side.
>>> 
>>> I actually was going to submit a patch that would remove sidx atoms being written out for any non-video content.
>>> 
>>> Is that now unnecessary because of your changes here?
>>> 
>>> So adding -movflags skip_sidx for our audio only fmp4 files would allow us to skip the sidx atoms?
>> Yes
> 
> Hey Tobias,
> 
> 
> So I just pulled HEAD and tried to use your support, but I can't figure out how to engage it:
> 
> ffmpeg -i input.mp4 -codec copy -hls_time 0.97523809523809 -hls_segment_type fmp4 -hls_flags single_file -hls_playlist_type vod -movflags skip_sidx output.m3u8
> ffmpeg -i input.mp4 -codec copy -hls_time 0.97523809523809 -hls_segment_type fmp4 -hls_flags single_file -hls_playlist_type vod -movflags skip_sidx=1 output.m3u8
> 
> None of these command lines produced an mp4 file without sidx atoms. The input.mp4 file is an audio only mp4 so I don't need sidx.
> 
> 

Looks like I found out why: https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/hlsenc.c#L790. The hlsenc.c file overwrites whatever I pass in the command line...


> Ronak
> 
>>> 
>>> Ronak
>>> 
>>>> 
>>>> Regards,
>>>> Tobias
>> 
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org <mailto:ffmpeg-devel at ffmpeg.org>
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>