[FFmpeg-devel] [PATCH] avcodec: rewrite gif muxing and encoding

[Paul B Mahol]

On 12/11/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2018-12-11 17:40 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>> On 12/11/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>> 2018-12-11 17:37 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>> On 12/11/18, Paul B Mahol <onemda at gmail.com> wrote:
>>>>> On 12/11/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>> 2018-12-11 17:18 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>>>>> On 12/11/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>>>> 2018-12-11 16:02 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>>>>>>> Now "-c copy" works.
>>>>>>>>
>>>>>>>> Please mention ticket #6640.
>>>>>>>>
>>>>>>>> When using the commands there, the output file has a different
>>>>>>>> byte at position 0xbb06 (0x0a -> 0x05), do you know why?
>>>>>>>
>>>>>>> Dunno, md5 of decoded output is same. I fixed some artifacts in last
>>>>>>> patch
>>>>>>
>>>>>> md5sum of original and decoded file is different here.
>>>>>
>>>>> Test latest patch.
>>>
>>> With the latest patch, md5sum of original and remuxed file are different
>>> here.
>>>
>>
>> Of course, you found single byte change.
>>
>>>> Test -f md5 - not md5sum.
>>>
>>> How can you compare a file and FFmpeg's output with -f md5?
>>
>> You do not know? How so?
>
> I have no idea.
>

It was about last packet duration, fixed locally.

Why pkt->duration is not propagated correctly when muxing?
So one does not need to delay writing by 1 packet.