[FFmpeg-devel] [PATCH]lavc/g729dec: Support stereo streams

[Carl Eugen Hoyos]

2018-12-14 15:52 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
> On 12/14/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>> 2018-12-12 23:44 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>> On 12/12/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>> 2018-12-12 23:30 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>>> On 12/12/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>> Hi!
>>>>>>
>>>>>> Attached patch fixes ticket #4553 for me.
>>>>>>
>>>>>> Please comment, Carl Eugen
>>>>>>
>>>>>
>>>>> I do not like what you did to G729Context.
>>>>
>>>>> Please rewrite patch.
>>>>> Move relevant parts into G729ChannelContext chan[2];
>>>>
>>>> Which part of the context does not need to be duplicated?
>>>
>>> AudioDSPContext adsp;
>>
>> New patch attached.
>>
>> Please comment, Carl Eugen
>
> No need to alloc channel context, just use fixed size: [2];

I assumed nearly all G.729 streams are mono and given
that this improvement was about avoiding an unneeded
allocation this version would be cleaner.
You don't agree?

Thank you, Carl Eugen