[FFmpeg-devel] [PATCH] Fix buffer resizing after probe done.

Artyom Lebedev vagran.ast at gmail.com
Wed Dec 19 14:40:56 EET 2018


I have this assert fired after probing done and frames are normally 
read: "av_assert0(len >= s->orig_buffer_size);". Buffer size after 
probing ended up with ~5MB, orig_buffer_size was 64K. This place looks 
like total mess, it definitely has a bug with incorrect len modification 
even if buffer was not resize (failure to do so was ignored as well). I 
did not get what is the purpose of "s->buf_ptr != dst" check as well as 
this assert itself, so I removed them, this code really needs some 
comments there.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-buffer-resizing-after-probe-done.patch
Type: text/x-patch
Size: 1956 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181219/13f0a0ea/attachment.bin>


More information about the ffmpeg-devel mailing list