[FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: replace obsolete comment
Marton Balint
cus at passwd.hu
Sun Dec 23 02:12:54 EET 2018
We no longer use strftime directly but use av_timegm to get an int64_t timestamp.
Signed-off-by: Marton Balint <cus at passwd.hu>
---
libavformat/mxfdec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 6e96107498..d78f8ad2e4 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -2563,9 +2563,7 @@ static int64_t mxf_timestamp_to_int64(uint64_t timestamp)
time.tm_min = (timestamp >> 16 & 0xFF);
time.tm_sec = (timestamp >> 8 & 0xFF);
- /* msvcrt versions of strftime calls the invalid parameter handler
- * (aborting the process if one isn't set) if the parameters are out
- * of range. */
+ /* Clip values for legacy reasons. Maybe we should return error instead? */
time.tm_mon = av_clip(time.tm_mon, 0, 11);
time.tm_mday = av_clip(time.tm_mday, 1, 31);
time.tm_hour = av_clip(time.tm_hour, 0, 23);
--
2.16.4
More information about the ffmpeg-devel
mailing list