[FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding

[Derek Buitenhuis]

On 24/12/2018 08:41, Guo, Yejun wrote:
>>> +                    size_t nb_rois = frame->rois_buf->size /
>>> + sizeof(AVFrameROI);
>>
>> I think we have some macros that do this already.
> 
> I tried a code search and do not find one, there is a similar macro which does not work for this case: #define FF_ARRAY_ELEMS(a) (sizeof(a) / sizeof((a)[0]))
> I might miss it, I'll try again to see if any luck.

Right, I was thinking of FF_ARRAY_ELEMS, and you're right. You can disregard this
comment from me.

> thanks, the new idea is to use an integer value instead of the enum.

OK. I'll take a look when teh new patch lands.

Thanks! ROI support is something avcodec has needed for a while.

Cheers,
- Derek