[FFmpeg-devel] patch for failing on WavPack DSD files

[David Bryant]

On 12/24/18 12:21 AM, Paul B Mahol wrote:
> On 12/24/18, David Bryant <david at wavpack.com> wrote:
>> On 11/21/18 9:50 PM, David Bryant wrote:
>>> On 11/20/18 10:58 PM, Peter Ross wrote:
>>>> On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote:
>>>>> Hi,
>>>>>
>>>>> Was made aware of this problem on Kodi:
>>>>>
>>>>> https://github.com/xbmc/xbmc/issues/14771
>>>>>
>>>>> I'm going to try to add full WavPack DSD support, but thought in the
>>>>> meantime it would be a good idea to detect and error out early.
>>>>>
>>>>> Thanks!
>>>> cool. is this dst-based, or your own algorithm?
>>>>
>>>> -- Peter
>>>> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
>>>>
>>>> _______________________________________________
>>>> ffmpeg-devel mailing list
>>>> ffmpeg-devel at ffmpeg.org
>>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> This is my own algorithm. Actually there are two: one is a byte-based
>>> algorithm that is very fast and the other is bit-based
>>> (like DST) that is slower but compresses better (and still uses less CPU
>>> than DST). If I had to make a rough estimation of the
>>> average compression ratios, it would be about 0.6 for the fast mode, 0.5
>>> for the high mode, and 0.4 for DST.
>>>
>>> -David
>>>
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> Hi. Is there anything else I can provide to help this along?
>>
>> The behavior of FFmpeg encountering WavPack DSD files without this patch is
>> pretty ugly...
> Yes, post full patch that adds DSD support in WavPack.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

I want to do that, but am swamped at work right now, so it will probably be a few months before I can get to that.

In the meantime, I think this patch would be a safe stopgap (and prevent the Kodi crash).

Thanks!

-David