[FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

[Michael Niedermayer]

On Thu, Feb 01, 2018 at 07:52:55PM +0530, Gyan Doshi wrote:
> On 1/29/2018 6:53 PM, Gyan Doshi wrote:
> >
> >On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote:
> >
> >>How did you test this patch?
> >
> >By remuxing with patched ffmpeg and then checking with ffprobe, but not
> >ffplay!
> ...
> >Sorry, I'll rework and submit.
> 
> Revised and tested patch attached.

>  mpegenc.c |   17 +++++++++++++++--
>  1 file changed, 15 insertions(+), 2 deletions(-)
> 21908814c802dffad710828d1e5ec27168586636  v2-0001-avformat-mpegenc-accept-PCM_DVD-streams.patch
> From 78757309bbfbc9d9e48aabd6babc9529f83d5950 Mon Sep 17 00:00:00 2001
> From: Gyan Doshi <gyandoshi at gmail.com>
> Date: Thu, 1 Feb 2018 19:12:03 +0530
> Subject: [PATCH v2] avformat/mpegenc - accept PCM_DVD streams
> 
> PCM_S16BE stream packets in MPEG-PS have a 3-byte header
> and recognized as PCM_DVD by the demuxer which prevents
> their proper remuxing in MPEG-1/2 PS.

its probably a good idea to add a fate test for this too.
(could be in a seperate patch)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180202/dd19eada/attachment.sig>