[FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

Carl Eugen Hoyos ceffmpeg at gmail.com
Sat Feb 10 23:12:19 EET 2018


2018-02-10 16:36 GMT+01:00 Kieran Kunhya <kieran618 at googlemail.com>:
> $subj. Still depends on simple_idct template patch

> +    FF_ALLOCZ_OR_GOTO(s->avctx, s->block32, 64 * 12 * sizeof(int32_t), fail)

I believe this should be sizeof(variable).

> +                }
> +                else {

Since this is still unusual in FFmpeg, I suggest to
merge the lines.

Thank you, Carl Eugen


More information about the ffmpeg-devel mailing list