[FFmpeg-devel] [PATCH] lavf/mpegts: add supplementary audio descriptor

Stefan Pöschel basic.master at gmx.de
Fri Feb 16 13:31:53 EET 2018


Am 16.02.2018 um 05:10 schrieb Aman Gupta:
> One option would be to re-use an existing flag.
> 
> AV_DISPOSITION_CLEAN_EFFECTS seems to have a similar meaning, but is
> already used for a different purpose in mpegts.c

Right, so this would not be a distinct indicator.

> Another option is AV_DISPOSITION_DESCRIPTIONS which has a similar meaning
> as well.

Mhh...I think this would rather mean to re-use this flag for a different
meaning of a different track type. IMO this would rather lead to confusion.

> Or, maybe it's best to create a new AV_DISPOSITION_* for this purpose.

Yes, this seems to be the best option. It should be as generic as
possible for any possible re-use in other use cases. What about
AV_DISPOSITION_DEPENDENT?

> I'm happy to write a patch for this if we can decide on whether using
> AV_DISPOSITION_DESCRIPTIONS
> makes sense, or come up with
> a good name for a new flag.
Great!

Regards,
	Stefan


More information about the ffmpeg-devel mailing list