[FFmpeg-devel] [PATCH] ffmpeg: pass the correct AVCodecContext to av_parser_change()

[James Almer]

On 2/22/2018 8:34 PM, Hendrik Leppkes wrote:
> On Fri, Feb 23, 2018 at 12:20 AM, James Almer <jamrial at gmail.com> wrote:
>> av_parser_change() is effectively a noop if the avctx passed it to
>> doesn't have the global header or local header flags set, and
>> initializing a custom AVCodecContext as a copy of an
>> AVCodecParameters results in the flags and flags2 fields being zero.
>> Use instead the existing custom AVCodecContext with the required
>> flags set in ffmpeg_opt.c new_output_stream() among other places.
>>
>> The fate test change is the result of the hevc sps/pps/vps being
>> removed from frames when copying into a format that explicitly
>> states it uses global header.
>>
> 
> Deleting inband headers is not necessarily a good idea, and likely
> also why its being skipped for h264.

Well, I'd argue it is when the user and/or the output format request it.

> 
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>