[FFmpeg-devel] [PATCH 2/3] avformat/dashenc: opening a segment file when its first frame is ready

[Jeyapal, Karthick]

On 2/24/18 9:11 PM, James Almer wrote:
> On 2/24/2018 12:19 PM, Marton Balint wrote:
>>
>>
>> On Mon, 19 Feb 2018, vdixit at akamai.com wrote:
>>
>>> From: Vishwanath Dixit <vdixit at akamai.com>
>>>
>>> ---
>>> libavformat/dashenc.c | 57
>>> ++++++++++++++++++++++++++++++++-------------------
>>> 1 file changed, 36 insertions(+), 21 deletions(-)
>>>
>>> diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c
>>> index 0f6f4f2..0eb4b25 100644
>>> --- a/libavformat/dashenc.c
>>> +++ b/libavformat/dashenc.c
>>> @@ -81,6 +81,9 @@ typedef struct OutputStream {
>>>     char bandwidth_str[64];
>>>
>>>     char codec_str[100];
>>> +    char filename[1024];
>>> +    char full_path[1024];
>>> +    char temp_path[1024];
>>> } OutputStream;
>>
>> I know it's late, but in the future please work toward supporting
>> unlimited path lengths, that was the whole point of the deprecation of
>> AVFormatContext->filename.
Thanks for pointing it out. Sure, we will fix it. We had done these long back(atleast 6 months back), when filename was still in active use.
Only now we had the time to merge these changes with the latest ffmpeg.
>>
>> Thanks,
>> Marton
>
> It's not late, it can and should be changed. New code using deprecated
> APIs that will require changes in the long run should have not been
> added, so better change it now.
Just to clarify here, we are not using any deprecated API in that patch. We are still using the url parameter.
In fact, yesterday I sent out a different patch to fix deprecated API usage that was previously present. http://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225739.html 
The only issue was that the size of filename has been limited to 1024 internally. This needs to be replaced by a dynamic size buffer.  
But I agree with you that it is better to change now rather than later. 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel