[FFmpeg-devel] [PATCH 5/6] lavd: add new API for iterating input and output devices

wm4 nfxjfg at googlemail.com
Wed Jan 3 17:48:12 EET 2018


On Wed, 3 Jan 2018 00:43:06 +0000
Josh de Kock <josh at itanimul.li> wrote:

> ---
>  configure                |  27 ++++++--
>  libavdevice/alldevices.c | 172 +++++++++++++++++++++++++++++++++++------------
>  libavdevice/avdevice.c   |  46 -------------
>  libavdevice/avdevice.h   |  28 ++++++++
>  libavdevice/version.h    |   4 ++
>  5 files changed, 184 insertions(+), 93 deletions(-)
> 

> +const AVOutputFormat *av_outdev_iterate(void **opaque)
> +{
> +    uintptr_t i = (uintptr_t)*opaque;
> +    const AVOutputFormat *f = outdev_list[i];
> +    if (f)
> +        *opaque = (void*)(i + 1);
> +    return f;
> +}
> +
> +const AVInputFormat *av_indev_iterate(void **opaque)
> +{
> +    uintptr_t i = (uintptr_t)*opaque;
> +    const AVInputFormat *f = indev_list[i];
> +
> +    if (f)
> +        *opaque = (void*)(i + 1);
> +    return f;
> +}

(Inconsistent spacing: why does the indev one have an empty line, but
the outev one not?)

> +    if (previn)
> +        previn->next = NULL;
> +}

(Still wondering if this is redundant.)

So, I think this commit lacks the APIchanges entry.

Same comment about pthread_once() again.


More information about the ffmpeg-devel mailing list