[FFmpeg-devel] [PATCH v2 1/2] http: block while waiting for reconnecting
wm4
nfxjfg at googlemail.com
Thu Jan 4 16:16:43 EET 2018
On Tue, 2 Jan 2018 17:19:14 +0100
wm4 <nfxjfg at googlemail.com> wrote:
> It makes no sense to return an error after the first reconnect, and then
> somehow resume the next time it's called. Usually this will lead to
> demuxer errors. Make reconnecting block instead, until it has either
> successfully reconnected, or given up.
>
> Also make the wait reasonably interruptible. Since there is no mechanism
> for this in the API, polling is the best we can do. This behaves roughly
> the same as other interruptible network functions in libavformat.
>
> (The original code would work if it returned AVERROR(EAGAIN) or so,
> which would make retry_transfer_wrapper() repeat the read call. But I
> think having an explicit loop for this is better anyway.)
>
> I also snuck in a fix for reconnect_at_eof. It has to check for
> AVERROR_EOF, not 0.
> ---
Both patches approved by BBB on IRC. Pushed.
More information about the ffmpeg-devel
mailing list