[FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

[Michael Niedermayer]

On Fri, Jan 05, 2018 at 10:26:42PM +0100, Jerome Martinez wrote:
> On 05/01/2018 16:14, Tobias Rapp wrote:
> >On 05.01.2018 11:18, Jerome Martinez wrote:
> >>0001-FFV1-make-RGB48-support-as-non-experimental.patch
> >>
> >>From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001
> >>From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome at mediaarea.net>
> >>Date: Fri, 5 Jan 2018 11:09:01 +0100
> >>Subject: [PATCH] FFV1: make RGB48 support as non-experimental
> >
> >make => mark
> 
> I reused a commit text from history, both words words were in it.
> Anyway, attached is the updated .patch with the suggested subject line.



> 
> >
> >BTW: common subject line format would be something like "avcodec/ffv1enc:
> >mark RGB48 support as non-experimental"
> 

>  ffv1enc.c |    4 ----
>  1 file changed, 4 deletions(-)
> acfc60c913b311b148f2eeef2d2d6ea9e37afcf7  0001-avcodec-ffv1enc-mark-RGB48-support-as-non-experiment.patch
> From 303f63fb7e6172fdb7de66da1f8a4006b79a535f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= <jerome at mediaarea.net>
> Date: Fri, 5 Jan 2018 11:09:01 +0100
> Subject: [PATCH] avcodec/ffv1enc: mark RGB48 support as non-experimental
> 
> Resulting bitstream was tested with a conformance checker
> using the last draft of FFV1 specifications.

But has the way this is stored been optimized ?

Once its marked as non exerimental all future decoders must support the exact
way. It can no longer then be changed, so we need to be really sure the design
is optimal first.
Are we ?
who has checked alternatives? what where the reasons why the alternatives
were not choosen?
for example consider get_context(), what it does with >8bit may or may not
be optimal
iam interrested to work on that in fact, ive a quite long and growing list
of other volunteer jobs to do though ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180106/6216ec07/attachment.sig>