[FFmpeg-devel] [PATCH] avfilter/vf_overlay: add comment into eval_expr

Michael Niedermayer michael at niedermayer.cc
Tue Jan 9 20:36:46 EET 2018


On Tue, Jan 09, 2018 at 10:41:44AM +0800, Steven Liu wrote:
> comment about the looks like a duplicate line.
> but that is used to reason x is expressed from y
> 
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> ---
>  libavfilter/vf_overlay.c | 1 +
>  1 file changed, 1 insertion(+)

LGTM, btw there were also other filters which do this


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180109/5dc92190/attachment.sig>


More information about the ffmpeg-devel mailing list