[FFmpeg-devel] [PATCH] Don't overwrite previously setup dimensions for all codecs

wm4 nfxjfg at googlemail.com
Thu Jan 11 07:41:48 EET 2018


On Thu, 11 Jan 2018 05:34:07 +0000
"Li, Zhong" <zhong.li at intel.com> wrote:

> > > IIUC, This commit was merged from Libav, checking the commit log of  
> > cf7d3846fc865df47bd64f7d4d10bbedf9e3a17b:
> > 
> > Yeah, but...
> >   
> > >     Merge commit '9de9b828ef005dec37052548c195a6b4f18fc701'
> > >
> > >     * commit '9de9b828ef005dec37052548c195a6b4f18fc701':
> > >       lavc: don't overwrite display dimensions with coded dimensions.
> > >       lavc: extend / update the [coded_]{width,height} doxy
> > >
> > >     Conflicts:
> > >         libavcodec/avcodec.h
> > >         libavcodec/utils.c
> > >
> > >     The change to the w/h handling is not merged as it breaks lowres
> > >
> > >     Merged-by: Michael Niedermayer <michaelni at gmx.at>  
> > 
> > This says this specific part was skipped. Apparently it broke lowres, an
> > obscure feature that probably nobody uses and that Libav removed.  
> 
> Yup... 9de9b82 was not merged as a whole. 
> I guess I am not the only one person who is confused why w/h are overwritten by coded_w/coded_h here (https://ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140142.html )
> For "lowres", is it still broken for H264/VP6F/DXV by current code?

I don't know (from the mail above this might be more an API problem?),
but I'd prefer your patch over the current situation as well.


More information about the ffmpeg-devel mailing list