[FFmpeg-devel] [PATCH] ffmpeg.c: use sigterm_handler with sigpipe

Nicolas George george at nsup.org
Thu Jan 18 17:05:39 EET 2018


Carl Eugen Hoyos (2018-01-18):
> Would you like to elaborate?

Of course, provided somebody is interested.

Issuing the following command:

	trap "" SIGPIPE

will ignore SIGPIPE in the shell and all subsequent programs started
from it. It will achieve exactly the result of this patch, in a much
cleaner way, without impacting others users.

> Maybe you could explain the drawbacks?

No, I cannot. I only know they exist, because signals on Unix are like
that. In this instance, I consider the burden of the proof to be on the
person who proposes the patch.

Still, there is always the fact that it changes the behaviour in a
significant way, possibly resulting in process running indefinitely
where they were stopping previously.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180118/2cf51144/attachment.sig>


More information about the ffmpeg-devel mailing list