[FFmpeg-devel] [PATCH] ffmpeg.c: use sigterm_handler with sigpipe

Nicolas George george at nsup.org
Thu Jan 18 17:45:35 EET 2018


Carl Eugen Hoyos (2018-01-18):
> We have disagreed in the past about pkg-config,
> you don't want me to test FFmpeg on less common
> systems, fine.

This is untrue. I have offered you help to find a work-flow to test
FFmpeg on less common systems while playing nice with pkg-config, but
you never accepted.

> Now you are again behaving childishly, be it because
> you don't like a patch, be it because you are in a
> bad mood.

Neither. Let me explain one last time.

Unix signals are an abomination, their behaviour is barely portable,
made mostly of undefined or implementation-defined behaviours, with a
lot of strange corner cases. They are also a very fragile edifice, with
some signals playing a very subtle but absolutely necessary role in the
correct workings of the system.

Programming with Unix signals should be reserved to very skilled
programmers. I usually do not even trust myself to touch them, except in
the simplest of cases; yet, if I say so myself, I think when it comes to
Unix system programming, I am rather ahead here.

I would not oppose a patch from a skilled Unix programmer who explains
the details of the behaviour changes and why they are good. But if
somebody just copy-paste a bit of code that looks vaguely similar and
says "I do not know what I am doing but it seems to fix my particular
use case", then I oppose. It would make things worse.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180118/e19e140a/attachment.sig>


More information about the ffmpeg-devel mailing list