[FFmpeg-devel] [PATCH] Fix float-cast-overflow undefined behavior in matroskadec

Niki Bowe nbowe at google.com
Fri Jan 19 03:06:25 EET 2018


In the file the fuzzer produced the frame rate is incredibly small
(7.29112e-304).
I thought %e (or %g if you prefer) produced the most appropriate and
readable log message.
Also happy to just remove the frame rate from the log if you prefer?

On Thu, Jan 18, 2018 at 4:02 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
wrote:

> 2018-01-19 0:21 GMT+01:00 Nikolas Bowe <nbowe-at-google.com at ffmpeg.org>:
>
> > +                  av_log(matroska->ctx, AV_LOG_WARNING,
> > +                         "Invalid frame rate %e. Cannot calculate
> default duration.\n",
> > +                         track->video.frame_rate);
>
> We currently have one ocurence of "%e" in the whole codebase
> and it is usually not compiled: Can you use %f here or would that
> be a disadvantage?
>
> Carl Eugen
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>



-- 

Nikolas Bowe |  SWE |  nbowe at google.com |  408-565-5137


More information about the ffmpeg-devel mailing list