[FFmpeg-devel] [PATCH 2/2] fate: add decoder test for ATRAC9

[James Almer]

On 7/1/2018 8:46 AM, Rostislav Pehlivanov wrote:
> Signed-off-by: Rostislav Pehlivanov <atomnuker at gmail.com>
> ---
>  tests/fate/atrac.mak | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak
> index acf79a539c..38a5f33150 100644
> --- a/tests/fate/atrac.mak
> +++ b/tests/fate/atrac.mak
> @@ -33,7 +33,17 @@ fate-atrac3p-2: REF = $(SAMPLES)/atrac3p/sonateno14op27-2-cut.pcm
>  
>  FATE_ATRAC3P-$(call DEMDEC, OMA, ATRAC3P) += $(FATE_ATRAC3P)
>  
> -FATE_ATRAC_ALL = $(FATE_ATRAC1-yes) $(FATE_ATRAC3-yes) $(FATE_ATRAC3P-yes)
> +FATE_ATRAC9 += fate-atrac9-1
> +fate-atrac9-1: CMD = pcm -i $(TARGET_SAMPLES)/atrac9/sy_title01.at9
> +fate-atrac9-1: REF = $(SAMPLES)/atrac9/sy_title01.at9.pcm
> +
> +FATE_ATRAC9 += fate-atrac9-2
> +fate-atrac9-2: CMD = pcm -i $(TARGET_SAMPLES)/atrac9/3_br144_nb10_ib10_g04_bex1_sf1_d1.at9
> +fate-atrac9-2: REF = $(SAMPLES)/atrac9/3_br144_nb10_ib10_g04_bex1_sf1_d1.at9.pcm

Are these pcm files from a test suit (if any), or at least created by an
official binary decoder?
I'd rather avoid adding tests using reference files created by this same
decoder, seeing you for example resent the patch three times to fix a
wrong calculation each time. You never know if you'll find others later,
which could result in different output that may just be different enough
to fail on some hardware (usually mips/arm/x86_32).

But if there is no other way, make sure to create the reference files
using cpuflags 0 using an x86_32 build (for x87 float math), and not
with asm enabled (imdct and such), or with an x86_64 build.
If you can't run a x86_32 build, I or someone else could do it instead.

> +
> +FATE_ATRAC9-$(call DEMDEC, OMA, ATRAC9) += $(FATE_ATRAC9)
> +
> +FATE_ATRAC_ALL = $(FATE_ATRAC1-yes) $(FATE_ATRAC3-yes) $(FATE_ATRAC3P-yes) $(FATE_ATRAC9-yes)
>  
>  $(FATE_ATRAC_ALL): CMP = oneoff
>  
> @@ -42,3 +52,4 @@ FATE_SAMPLES_AVCONV += $(FATE_ATRAC_ALL)
>  fate-atrac:   $(FATE_ATRAC_ALL)
>  fate-atrac3:  $(FATE_ATRAC3-yes)
>  fate-atrac3p: $(FATE_ATRAC3P-yes)
> +fate-atrac9:  $(FATE_ATRAC9-yes)
>