[FFmpeg-devel] [PATCH] libavcodec/mpegaudiodecheader.h : detect reserved mpeg id

[Karsten Otto]

Argh, just noticed a stupid mistake - quite obviously, the check pattern
needs to be shifted too, i.e. 1<<19 instead of just 1. Luckily, it won't do
any harm, since it can never evaluate to true.

What is the protocol in this case - Do I send a new version of the patch?
Or another patch to the patch that is already applied?

Sorry for the inconvenience,
Karsten

> Am 09.07.2018 um 02:46 schrieb Michael Niedermayer <michael at niedermayer.cc>:
> 
> Signierter PGP-Teil
> On Sun, Jul 08, 2018 at 12:26:10PM +0200, Karsten Otto wrote:
>> Check the MPEG version ID for the reserved bit pattern 01, and abort the
>> header check in that case. This reduces the chance of misinterpreting
>> arbitrary data as a valid header, and prevents resulting audio artifacts.
>> ---
>> libavcodec/mpegaudiodecheader.h | 3 +++
>> 1 file changed, 3 insertions(+)
> 
> will apply
> 
> thx
> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> When the tyrant has disposed of foreign enemies by conquest or treaty, and
> there is nothing more to fear from them, then he is always stirring up
> some war or other, in order that the people may require a leader. -- Plato
> 
>