[FFmpeg-devel] [PATCH v5] Add lensfun filter

[Moritz Barsnick]

On Fri, Jul 13, 2018 at 12:07:05 +0900, Stephen Seo wrote:
> > If you're logging the model on success, you might as well also log it
> > on failure.
> Actually, it is impossible to log the model because on failure, the pointer
> to camera/lens is NULL, which is where such info is originally derived from.

You're right, of course. I confused that a bit with the actual command
line option strings lensfun->make and lensfun->model. Since the user
*should* know their command line, probably no need to print the failing
string (but wouldn't hurt either).

> Since it is possible for users to supply an incomplete string of the
> camera/lens model I figure it would be helpful to log the camera/lens
> model chosen by the filter

Absolutely.

Cheers,
Moritz