[FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

[Thilo Borgmann]

[...]
> 0001-avfilter-added-colorconstancy.patch
> 
> 
> From 75ff45f28690cf208058315e4a3ec48e7981b837 Mon Sep 17 00:00:00 2001
> From: Mina <minasamy_ at hotmail.com>
> Date: Thu, 12 Jul 2018 20:19:55 +0200
> Subject: [PATCH] avfilter: added colorconstancy
> 
> Signed-off-by: Mina <minasamy_ at hotmail.com>
> ---
>  Changelog                       |   1 +
>  MAINTAINERS                     |   1 +
>  libavfilter/Makefile            |   1 +
>  libavfilter/allfilters.c        |   1 +
>  libavfilter/vf_colorconstancy.c | 808 ++++++++++++++++++++++++++++++++
>  5 files changed, 812 insertions(+)
>  create mode 100644 libavfilter/vf_colorconstancy.c
> [...]

> +/**
> + * Appends estimated illumination to a file; mainly for later usage in other
> + * algorithms.
> + *
> + * @param ctx the filter context.
> + *
> + * @return 0 in case of success, a negative value corresponding to an
> + * AVERROR code in case of failure.
> + */
> +static int save_tofile(AVFilterContext *ctx)

If the output is not yet used for anything, this function should be introduced once reading that has become useful, too.

However, I don't know if that is the way we tend to do metadata/intermediate output to files. Therefore, I'd appreciate any comments about if that has to be done differently (in a future patch most likely).

Thanks,
Thilo