[FFmpeg-devel] [PATCH] fate: add more vc2 encoder tests

[Michael Niedermayer]

On Sat, Jul 14, 2018 at 10:42:25PM +0200, James Darnley wrote:
> On 2018-07-14 17:58, Michael Niedermayer wrote:
> > On Fri, Jul 13, 2018 at 08:09:57PM +0200, James Darnley wrote:
> >> From: James Darnley <james.darnley at gmail.com>
> >>
> >> ---
> >>  tests/fate/vcodec.mak                 | 24 ++++++++++++++++--------
> >>  tests/ref/vsynth/vsynth1-vc2-5_3      |  4 ++++
> >>  tests/ref/vsynth/vsynth1-vc2-haar     |  4 ++++
> >>  tests/ref/vsynth/vsynth2-vc2-5_3      |  4 ++++
> >>  tests/ref/vsynth/vsynth2-vc2-haar     |  4 ++++
> >>  tests/ref/vsynth/vsynth_lena-vc2-5_3  |  4 ++++
> >>  tests/ref/vsynth/vsynth_lena-vc2-haar |  4 ++++
> >>  7 files changed, 40 insertions(+), 8 deletions(-)
> >>  create mode 100644 tests/ref/vsynth/vsynth1-vc2-5_3
> >>  create mode 100644 tests/ref/vsynth/vsynth1-vc2-haar
> >>  create mode 100644 tests/ref/vsynth/vsynth2-vc2-5_3
> >>  create mode 100644 tests/ref/vsynth/vsynth2-vc2-haar
> >>  create mode 100644 tests/ref/vsynth/vsynth_lena-vc2-5_3
> >>  create mode 100644 tests/ref/vsynth/vsynth_lena-vc2-haar
> >>
> >> diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak
> >> index bbcf25d72a..7c11243678 100644
> >> --- a/tests/fate/vcodec.mak
> >> +++ b/tests/fate/vcodec.mak
> > 
> > this seems to break:
> > make: *** [fate-vsynth1-vc2-420p10] Error 1
> > make: *** [fate-vsynth1-vc2-420p12] Error 1
> > make: *** [fate-vsynth1-vc2-422p10] Error 1
> > make: *** [fate-vsynth1-vc2-422p12] Error 1
> > make: *** [fate-vsynth1-vc2-444p10] Error 1
> > make: *** [fate-vsynth1-vc2-444p12] Error 1
> > make: *** [fate-vsynth1-vc2-420p] Error 1
> > make: *** [fate-vsynth1-vc2-422p] Error 1
> > make: *** [fate-vsynth1-vc2-444p] Error 1
> > make: *** [fate-vsynth2-vc2-420p10] Error 1
> > make: *** [fate-vsynth2-vc2-420p12] Error 1
> > make: *** [fate-vsynth2-vc2-422p12] Error 1
> > make: *** [fate-vsynth2-vc2-422p10] Error 1
> > make: *** [fate-vsynth2-vc2-420p] Error 1
> > make: *** [fate-vsynth2-vc2-444p10] Error 1
> > make: *** [fate-vsynth2-vc2-444p12] Error 1
> > make: *** [fate-vsynth2-vc2-422p] Error 1
> > make: *** [fate-vsynth2-vc2-444p] Error 1
> > make: *** [fate-vsynth_lena-vc2-420p12] Error 1
> > make: *** [fate-vsynth_lena-vc2-420p10] Error 1
> > make: *** [fate-vsynth_lena-vc2-422p10] Error 1
> > make: *** [fate-vsynth_lena-vc2-422p12] Error 1
> > make: *** [fate-vsynth_lena-vc2-444p10] Error 1
> > make: *** [fate-vsynth_lena-vc2-444p12] Error 1
> > make: *** [fate-vsynth_lena-vc2-420p] Error 1
> > make: *** [fate-vsynth_lena-vc2-422p] Error 1
> > make: *** [fate-vsynth_lena-vc2-444p] Error 1
> 
> Dammit.  works4me though.  Maybe make doesn't like the "pattern
> matching" done in them.  since those seem to be the existing tests I
> will adjust the patterns used for the new ones.  Can you run one of
> those failing ones with V=1 and show the full commandline and output?  I
> guess it might be trying to pass a weird value as the wavelet_type option.

of course

make fate-vsynth_lena-vc2-444p12 V=1
ffmpeg/ffmpeg -nostdin -nostats -cpuflags all -f rawvideo -s 352x288 -pix_fmt yuv420p -threads 1 -idct simple -flags +bitexact -sws_flags +accurate_rnd+bitexact -fflags +bitexact -hwaccel none -threads 1 -thread_type frame+slice -i ffmpeg/tests/data/vsynth_lena.yuv -threads 1 -idct simple -dct fastint -c vc2 -pix_fmt yuv422p10 -c:v vc2 -frames 5 -strict -1 -wavelet_type 444p12 -flags +bitexact -sws_flags +accurate_rnd+bitexact -fflags +bitexact -f mov -y ffmpeg/tests/data/fate/vsynth_lena-vc2-444p12.mov

...

[SMPTE VC-2 encoder @ 0x2a42640] [Eval @ 0x7ffd711f9930] Invalid chars '12' at the end of expression '444p12'
[SMPTE VC-2 encoder @ 0x2a42640] Unable to parse option value "444p12"
[SMPTE VC-2 encoder @ 0x2a42640] Error setting option wavelet_type to value 444p12.
Error initializing output stream 0:0 -- Error while opening encoder for output stream #0:0 - maybe incorrect parameters such as bit_rate, rate, width or height
Conversion failed!
make: *** [fate-vsynth_lena-vc2-444p12] Error 1


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180714/c49a0126/attachment.sig>