[FFmpeg-devel] [PATCH] avformat/movenc: implicitly enable negative CTS offsets for ismv

Jan Ekström jeebjp at gmail.com
Sat Jul 28 19:10:47 EEST 2018


On Fri, Jul 27, 2018 at 1:30 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> breaks fate
>

fate-lavf-ismv seems to be all about the version identifier (0 is for
uintXX CTS offsets, and 1 is for intXX CTS offsets). F.ex. with the
first file:

diff --git a/old_1st.log b/new_1st.log
index f188075577..5100ff6710 100644
--- a/old_1st.log
+++ b/new_1st.log
@@ -267,7 +267,7 @@
             [trun: Track Fragment Run Box]
                 position = 851
                 size = 120
-                version = 0
+                version = 1
                 flags = 0x000305
                     data-offset-present
                     first-sample-flags-present
@@ -350,7 +350,7 @@
             [trun: Track Fragment Run Box]
                 position = 143053
                 size = 120
-                version = 0
+                version = 1
                 flags = 0x000305
                     data-offset-present
                     first-sample-flags-present
@@ -433,7 +433,7 @@
             [trun: Track Fragment Run Box]
                 position = 284519
                 size = 32
-                version = 0
+                version = 1
                 flags = 0x000305
                     data-offset-present
                     first-sample-flags-present

Will send a new patch with that test updated.

Jan


More information about the ffmpeg-devel mailing list