[FFmpeg-devel] [PATCH] avdevice/xcbgrab: check return values of xcb query functions

Moritz Barsnick barsnick at gmx.net
Wed Jun 27 11:26:23 EEST 2018


On Wed, Jun 27, 2018 at 10:21:51 +0200, Moritz Barsnick wrote:
> Subject: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: check return values of xcb query functions

Sorry, I had told git send-email to use [PATCH v2]. *shrug*

> +        if (!p) {
> +            av_log(c, AV_LOG_ERROR, "Cannot get xcb pointer\n");

The value of the messages is debatable. Feel free to discuss.

This gives such an error using ffmpeg command line with this patch:
> [xcbgrab indev @ 0xa156740] Cannot get xcb pointer
> :1: Input/output error

The last line may suffice.

Thanks,
Moritz


More information about the ffmpeg-devel mailing list