[FFmpeg-devel] Type mismatch in ADPCM

[Carlo Bramini]

Hello,
I see. I expected that adding that could be considered out of the coding guidelines.
However, what about the patch attached for fixing the declaration of ff_adpcm_afc_coeffs[2][16]?
Although it works because the binary values are the same, this is wrong, independently by the fact that you are compiling for plain C or C++.

Sincerely.


> Il 10 marzo 2018 alle 20.38 Carl Eugen Hoyos <ceffmpeg at gmail.com> ha scritto:
> 
> 2018-03-10 15:02 GMT+01:00 Carlo Bramini <carlo.bramix at libero.it>:
> 
> > I noticed this thing because I compiled those sources with a more robust syntax check, by using C++ rather that plain C. At pratical level, nothing changed, except for the .h files that required to use the extern "C" keyword. I was wondering if you could evaulate the chance to add this feature to the include files.
> > It could be done directly by using some #ifdef/#endif, or perhaps by doing something like this, somewhere in a common file:
> > 
> > #ifdef __cplusplus
> > 
> > #define FFMPEG_EXTERN_C_BEGIN extern "C" {
> > 
> > #define FFMPEG_EXTERN_C_END }
> > 
> > #else
> > 
> > #define FFMPEG_EXTERN_C_BEGIN
> > 
> > #define FFMPEG_EXTERN_C_END
> > 
> > #endif
> 
> In addition to what was said:
> We cannot commit above because we would not test it
> and we cannot guarantee that it will always work: We
> provide C headers, if you want to use them in a C++
> project, it is your responsibility to make sure it works,
> not ours.
> 
> Carl Eugen
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel