[FFmpeg-devel] [PATCH 1/4] lavf/movenc: fix leak of eac3_priv

[Michael Niedermayer]

On Mon, Mar 12, 2018 at 11:46:45PM -0500, Rodger Combs wrote:
> This could previously happen in error or early-exit cases. The next commit
> would make it happen in all cases.
> ---
>  libavformat/movenc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 5b1e66c897..353a42ae2c 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -5772,6 +5772,7 @@ static void mov_free(AVFormatContext *s)
>              av_freep(&mov->tracks[i].par);
>          av_freep(&mov->tracks[i].cluster);
>          av_freep(&mov->tracks[i].frag_info);
> +        av_freep(&mov->tracks[i].eac3_priv);
>  
>          if (mov->tracks[i].vos_len)
>              av_freep(&mov->tracks[i].vos_data);

eac3_priv.pkt may need freeing too


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180314/83a81335/attachment.sig>