[FFmpeg-devel] [PATCH 2/2] avcodec/noise_bsf: move the reference in the bsf internal buffer

James Almer jamrial at gmail.com
Sun Mar 18 03:39:25 EET 2018


On 3/17/2018 10:28 PM, Michael Niedermayer wrote:
> On Fri, Mar 16, 2018 at 08:16:01PM -0300, James Almer wrote:
>> There's no need to allocate a new packet for it.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/noise_bsf.c | 30 ++++++++----------------------
>>  1 file changed, 8 insertions(+), 22 deletions(-)
> 
> should be ok assumung the the packet from ff_bsf_get_packet_ref can be
> modified, this is not documented in bsf.h

Yes, ff_bsf_get_packet_ref() moves the reference from the internal bsf
packet as stored by av_bsf_send_packet() to the already allocated packet
passed by the caller, whereas ff_bsf_get_packet() hands a newly
allocated packet with the reference to the caller.

> 
> thx
> 
> [...]
> 
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 



More information about the ffmpeg-devel mailing list