[FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

[Tobias Rapp]

On 21.03.2018 00:04, Michael Niedermayer wrote:
> On Tue, Mar 20, 2018 at 09:36:51AM +0100, Tobias Rapp wrote:
>> On 20.03.2018 02:44, Michael Niedermayer wrote:
>>> On Mon, Mar 19, 2018 at 09:31:44AM +0100, Tobias Rapp wrote:
>>>> On 14.03.2018 09:55, Tobias Rapp wrote:
>>>>> Allows to set the AV_LOG_PRINT_LEVEL and AV_LOG_SKIP_REPEATED flags
>>>>> using a distinct command-line option, similar to other flag options.
>>>>> Previously only the AV_LOG_SKIP_REPEATED flag was supported as a prefix
>>>>> to the "loglevel" option value.
>>>>>
>>>>> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
>>>>> ---
>>>>>   doc/fftools-common-opts.texi | 13 +++++++++++++
>>>>>   fftools/cmdutils.c           | 31 +++++++++++++++++++++++++++++++
>>>>>   fftools/cmdutils.h           |  6 ++++++
>>>>>   3 files changed, 50 insertions(+)
>>>>>
>>>>> [...]
>>>>
>>>> Any opinions? My motivation was adding support for AV_LOG_PRINT_LEVEL on the
>>>> CLI. Using the existing flags option string parsing functions seemed easier
>>>> and more consistent that extending the custom loglevel string parser.
>>>
>>> this means the feature would require every user app to add similar code
>>> if one wants to support it.
>>>
>>> it would be better if apps do not need changes for added options
>>
>> Not sure I understand. Do you mean user apps that link to libav* libraries
>> and want to mimic the command-line options of ffmpeg/ffprobe/ffplay?
> 
> no, i mean that a user app doesnt want to support each option by specific code
> most user apps just want things to work without changes
> 
> imagine each option for each codec would need a change to each user app
> ... unpractical ...
> 
> 
>> What
>> alternative would you suggest for managing AV_LOG_PRINT_LEVEL via
>> command-line options?
> 
> whatever parses the log level could also do all options
> or am i missing something ?

No existing option is changed or removed, just some new option is added. 
So user apps (like scripts that call ffmpeg binaries, I assume) wouldn't 
need changes.

But it seems a solution that merges into the existing "loglevel" option 
is preferred, so will work on that instead.

Regards,
Tobias