[FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

[Michael Niedermayer]

On Tue, Mar 27, 2018 at 02:26:45AM +0300, Даниил Чередник wrote:
> Now it should be fine. Second patch has been fixed.
> 
> On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник <dan.cherednik at gmail.com>
> wrote:
> 
> > Hi.
> > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind
> > during patch preparation, it was ok.
> > I will fix it, and send updated patch.
> >
> > Thank you!
> >
> > On Sun, Mar 25, 2018 at 5:57 PM, Michael Niedermayer <
> > michael at niedermayer.cc> wrote:
> >
> >> On Sun, Mar 25, 2018 at 01:55:42PM +0300, Даниил Чередник wrote:
> >> [...]
> >>
> >> >  libavcodec/dcaenc.c   |  369 ++++++++++++++++++++----------
> >> --------------------
> >> >  libavcodec/psymodel.c |    1
> >> >  tests/fate/acodec.mak |    4
> >> >  3 files changed, 156 insertions(+), 218 deletions(-)
> >> > fd146632a7f29530a59d35abd63149c81b4dfcc6
> >> 0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch
> >> > From 99d937a0828bbd60aef52d7979c75f8c21989145 Mon Sep 17 00:00:00 2001
> >> > From: Daniil Cherednik <dan.cherednik at gmail.com>
> >> > Date: Sun, 4 Mar 2018 13:14:17 +0000
> >> > Subject: [PATCH 2/2] avcodec/dcaenc: Use aac psychoacoustic model for
> >> DCA
> >> >  encoder
> >> >
> >> > There are several reasons to replace dca psychoacoustic to common model:
> >> >  - dca psychoacoustic has some quality problems especially at high
> >> frequency bands
> >> >  - unclear implementation
> >> >  - aac implementation allows to use tonality measurement for future
> >> improvements
> >> >  - a bit faster
> >>
> >> This breaks
> >> make -j12 fate-acodec-dca
> >> (segfaults)
> >>
> >> tell me if you can reproduce? If not ill rebuild with debug symbols and
> >> get a
> >> backtrace
> >>
> >> [...]
> >> --
> >> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> >>
> >> If you drop bombs on a foreign country and kill a hundred thousand
> >> innocent people, expect your government to call the consequence
> >> "unprovoked inhuman terrorist attacks" and use it to justify dropping
> >> more bombs and killing more people. The technology changed, the idea is
> >> old.
> >>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >>
> >
> >
> > --
> > Daniil Cherednik
> >
> 
> 
> 
> -- 
> Daniil Cherednik

[...]

> 57b2e6d001a856c9434fe6ad1856cb3f24443a83  0002-avcodec-dcaenc-Use-aac-psychoacoustic-model-for-DCA-.patch
> From 49b4f2a966719c24f54c026c438680557c35e96b Mon Sep 17 00:00:00 2001
> From: Daniil Cherednik <dan.cherednik at gmail.com>
> Date: Sun, 4 Mar 2018 13:14:17 +0000
> Subject: [PATCH 2/2] avcodec/dcaenc: Use aac psychoacoustic model for DCA
>  encoder
> 
> There are several reasons to replace dca psychoacoustic to common model:
>  - dca psychoacoustic has some quality problems especially at high frequency bands
>  - unclear implementation
>  - aac implementation allows to use tonality measurement for future improvements
>  - a bit faster
> 
> Signed-off-by: Daniil Cherednik <dan.cherednik at gmail.com>
> ---
>  libavcodec/dcaenc.c   | 369 +++++++++++++++++++++-----------------------------
>  libavcodec/psymodel.c |   1 +
>  tests/fate/acodec.mak |   4 +-
>  3 files changed, 156 insertions(+), 218 deletions(-)

breaks fate on arm qemu

TEST    acodec-dca
--- -	2018-03-29 00:37:01.286083392 +0200
+++ tests/data/fate/acodec-dca	2018-03-29 00:37:01.283607451 +0200
@@ -1 +1 @@
-c610f911aa74656132abb650be6b548a
+503d8eac7238d87aae6f92808231e0c0
Test acodec-dca failed. Look at tests/data/fate/acodec-dca.err for details.
make: *** [fate-acodec-dca] Error 1
 

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180329/102e104a/attachment.sig>