[FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

[Michael Niedermayer]

On Wed, Mar 28, 2018 at 07:02:48PM +0300, Timo Teräs wrote:
> iTunes currently uses the 'cprt' atom to store the copyright notice
> and this patch fixes compatibility with majority of software that
> supports the 'ilst' atom. Other software and documentation using this:
>  - AtomicParseley encodes and parses only 'cprt'
>  - Most players recognize only 'cprt'
>  - https://sno.phy.queensu.ca/~phil/exiftool/TagNames/QuickTime.html
>    documents both tag types
>  - http://mutagen.readthedocs.io/en/latest/api/mp4.html documents
>    only 'cprt'
> 
> ffmpeg mov reader properly parses the 'cprt' tag inside 'ilst' tag
> and functions correctly with streams produced with this commit.
> 
> Since 'cprt' seems to be the current correct atom, it is used by
> default. "-movflags legacy_copyright" option is added to revert
> back to the old atom type in case that is needed.
> 
> Signed-off-by: Timo Teräs <timo.teras at iki.fi>
> ---
> If the legacy option is not needed, I'm happy to resend patch just
> changing the atom types.

why dont you store both ?
the old should do no harm or am i missing something ?
and it avoids the need for the user parameter (which few will find if
they run in a file that doesnt work)

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180329/aad3c5dc/attachment.sig>