[FFmpeg-devel] [PATCH] mpegvideo: remove support for libxvid's RC system

[Michael Niedermayer]

On Wed, May 02, 2018 at 10:23:08PM +0100, Rostislav Pehlivanov wrote:
> On 2 May 2018 at 21:19, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 
> > 2018-05-02 5:35 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
> > > On 1 May 2018 at 21:58, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > >
> > >> 2018-05-01 21:00 GMT+02:00, Rostislav Pehlivanov <atomnuker at gmail.com>:
> > >> > Its a reminder of a bygone era. Less flexible than the internal RC
> > >> > system, probably worse and most definitely broken. Drop it. No one
> > >> > ever used it either, except for mislead people.
> > >>
> > >> Sorry for my bad git knowledge:
> > >> Is the above part of the commit message?
> > >>
> > >> Carl Eugen
> >
> > > Yep, its part of the commit message.
> >
> > Then the patch cannot be committed as-is.
> >
> 
> Why?
> 
> 
> 
> > Please wait for a comment from the maintainer, Carl Eugen

The commit message is (unnecessarily) offensive.

About the removial itself, its a question if theres someone who 
used/ wants to use this and wants to continue to use it. 
(thats something i do not know)

I certainly can look into fixing it if theres someone who uses this. In fact
i was not aware of this being broken, but i think i havnt tested it for a long
time so it very well could be broken.

If OTOH noone uses / wants to use it then well there wouldnt be much point
in keeping it


Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180503/208a45cf/attachment.sig>