[FFmpeg-devel] [PATCH] dcaenc: fix segfault when attempting to encode with invalid samplerate

Paul B Mahol onemda at gmail.com
Sat May 5 20:59:58 EEST 2018


On 5/5/18, Rostislav Pehlivanov <atomnuker at gmail.com> wrote:
> ---
>  libavcodec/dcaenc.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/dcaenc.c b/libavcodec/dcaenc.c
> index 186997c631..4b4ceeff05 100644
> --- a/libavcodec/dcaenc.c
> +++ b/libavcodec/dcaenc.c
> @@ -152,8 +152,11 @@ static int subband_bufer_alloc(DCAEncContext *c)
>
>  static void subband_bufer_free(DCAEncContext *c)
>  {
> -    int32_t *bufer = c->subband[0][0] - DCA_ADPCM_COEFFS;
> -    av_freep(&bufer);
> +    if (c->subband[0][0]) {
> +        int32_t *bufer = c->subband[0][0] - DCA_ADPCM_COEFFS;
> +        av_free(bufer);
> +        c->subband[0][0] = NULL;
> +    }
>  }
>
>  static int encode_init(AVCodecContext *avctx)

LGTM


More information about the ffmpeg-devel mailing list