[FFmpeg-devel] [PATCH 11/13] avformat/mxfenc: Write Audio Ref Level for D10

[Michael Niedermayer]

On Tue, May 08, 2018 at 01:02:19PM +0200, Tomas Härdin wrote:
> mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >      // Generic Sound Essence Descriptor
> >      { 0x3D02, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x04,0x04,0x02,0x03,0x01,0x04,0x00,0x00,0x00}}, /* Locked/Unlocked */
> >      { 0x3D03, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x02,0x03,0x01,0x01,0x01,0x00,0x00}}, /* Audio sampling rate */
> > +    { 0x3D04, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x01,0x04,0x02,0x01,0x01,0x03,0x00,0x00,0x00}}, /* Audio Ref Level */
> >      { 0x3D07, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x05,0x04,0x02,0x01,0x01,0x04,0x00,0x00,0x00}}, /* ChannelCount */
> >      { 0x3D01, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x04,0x04,0x02,0x03,0x03,0x04,0x00,0x00,0x00}}, /* Quantization bits */
> >      { 0x3D06, {0x06,0x0E,0x2B,0x34,0x01,0x01,0x01,0x02,0x04,0x02,0x04,0x02,0x00,0x00,0x00,0x00}}, /* Sound Essence Compression */
> > @@ -1333,6 +1334,8 @@ static void mxf_write_generic_sound_common(AVFormatContext *s, AVStream *st, con
> >  
> >      if (s->oformat == &ff_mxf_opatom_muxer)
> >          duration_size = 12;
> > +    if (s->oformat == &ff_mxf_d10_muxer)
> > +        size += 5;
> >  
> >      mxf_write_generic_desc(s, st, key, size+duration_size+5+12+8+8);
> >  
> > @@ -1350,6 +1353,11 @@ static void mxf_write_generic_sound_common(AVFormatContext *s, AVStream *st, con
> >      avio_wb32(pb, st->codecpar->sample_rate);
> >      avio_wb32(pb, 1);
> >  
> > +    if (s->oformat == &ff_mxf_d10_muxer) {
> > +        mxf_write_local_tag(pb, 1, 0x3D04);
> > +        avio_w8(pb, 0);
> > +    }
> 
> Sizes and such look OK, but again I don't know what the D-10 spec says

double checked
Table A2 - Generic Sound Essence Descriptor in SMPTE 386M lists 0

will apply

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/16371150/attachment.sig>