[FFmpeg-devel] [PATCH 6/6] fate/cbs: Add an SEI test
James Almer
jamrial at gmail.com
Thu May 10 01:51:21 EEST 2018
On 5/7/2018 9:30 PM, Mark Thompson wrote:
> On 08/05/18 01:06, James Almer wrote:
>> On 5/7/2018 8:11 PM, Mark Thompson wrote:
>>> The artificial sample file sei-1.h264 contains five frames (IDR P B I B)
>>> and the following SEI message types:
>>> * Buffering period
>>> * Picture timing
>>> * Pan-scan rectangle (display as 4:3)
>>> * User data registered, containing A/53 closed captions (captions match
>>> frame content, including reordering)
>>> * Recovery point (at the I frame)
>>> * Display orientation (identity transformation)
>>> * Mastering display (with arbitrary contents)
>>> * Undefined SEI type 1234 (containing ascending bytes)
>>> ---
>>> Sample file at <http://ixia.jkqxz.net/~mrt/ffmpeg/sei-1.h264>. (Named -1 anticipating the possibility of adding more in future.)
>>>
>>> 140ddba635960ac73935a0fb268748a43c647151 fate/h264/sei-1.h264
>>
>> If you crafted this file using the mastering display implementation from
>> patch 5/6 then you may need to create it again with the fixed element sizes.
>
> It didn't change because the numbers I had there were < 2^16, but I've regenerated anyway with a larger number as max so that it does get tested.
>
> b8f3b5443c8e437a83d36a72657478529c2afcfc fate/h264/sei-1.h264
Uploaded then.
>
>>>
>>>
>>> tests/fate/cbs.mak | 8 ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/fate/cbs.mak b/tests/fate/cbs.mak
>>> index bee349ed45..911e7704aa 100644
>>> --- a/tests/fate/cbs.mak
>>> +++ b/tests/fate/cbs.mak
>>> @@ -14,7 +14,7 @@ endef
>>>
>>> # H.264 read/write
>>>
>>> -FATE_CBS_H264_SAMPLES = \
>>> +FATE_CBS_H264_CONFORMANCE_SAMPLES = \
>>> SVA_Base_B.264 \
>>> BASQP1_Sony_C.jsv \
>>> FM1_BT_B.h264 \
>>> @@ -30,7 +30,11 @@ FATE_CBS_H264_SAMPLES = \
>>> CVSE2_Sony_B.jsv \
>>> CABACI3_Sony_B.jsv
>>>
>>> -$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
>>> +FATE_CBS_H264_SAMPLES = \
>>> + sei-1.h264
>>> +
>>> +$(foreach N,$(FATE_CBS_H264_CONFORMANCE_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264-conformance/$(N),h264)))
>>> +$(foreach N,$(FATE_CBS_H264_SAMPLES),$(eval $(call FATE_CBS_TEST,h264,$(basename $(N)),h264/$(N),h264)))
>>
>> Missing ref files? Or it doesn't generate them?
>
> Missed, sorry:
>
> diff --git a/tests/ref/fate/cbs-h264-sei-1 b/tests/ref/fate/cbs-h264-sei-1
> new file mode 100644
> index 0000000000..2d1cb1fe7f
> --- /dev/null
> +++ b/tests/ref/fate/cbs-h264-sei-1
> @@ -0,0 +1 @@
> +5f537551b7dfab76a172f1aebb028986
>
>>>
>>> FATE_CBS_H264-$(call FATE_CBS_DEPS, H264, H264, H264, H264, H264) = $(FATE_CBS_h264)
>>> FATE_SAMPLES_AVCONV += $(FATE_CBS_H264-yes)
>>>
>
> Thanks,
>
> - Mark
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
More information about the ffmpeg-devel
mailing list