[FFmpeg-devel] [PATCH] lavc,lavf: add libxavs2 encoder

[Moritz Barsnick]

On Sat, May 26, 2018 at 14:08:56 +0800, hwren wrote:
> Add Chinese AVS2 video encoder, FFmpeg can make use of the libxavs2 library for AVS2 encoding.
[...]
> +    .long_name         = NULL_IF_CONFIG_SMALL("raw Chinese AVS2 (2nd Audio Video Standard)"),

Is that really the name of the codec? Otherwise, "Chinese" seems
awkward to me. (Same for the decoder.)

> +Go to @url{https://github.com/pkuvcl/xavs2} and follow the instructions for
> +installing the library. Then pass @code{--enable-libxavs2} to configure to
> +enable it.

Proper documentation of the encoder's options would be appreciated!

One more important thing: libdavs2 and libxavs2 are licensed under
GPL2, not LGPL. You therefore need a handful of extra boilerplate in
configure (such as EXTERNAL_LIBRARY_GPL_LIST, and adding "gpl" as a
dependency), as far as I understand.

Cheers,
Moritz